Skip to content

Support stable theme customization names on iOS 26 - #145

Merged
rdlabo merged 4 commits into
ios26from
fix/ios26-stable-theme-names
Sep 10, 2026
Merged

Support stable theme customization names on iOS 26#145
rdlabo merged 4 commits into
ios26from
fix/ios26-stable-theme-names

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Applications sharing customizations between the iOS 26 and iOS 27 themes need version-independent opt-out classes and CSS variables. Add ios-theme-disabled and --ios-theme-* support to the iOS 26 theme.

ios26-disabled remains a deprecated alias in styles and popover animation selection. Each new CSS variable takes precedence over its corresponding deprecated --ios26-* fallback, preserving existing customizations. Package names, stylesheet paths, and default styling remain unchanged. The migration guide includes a rename table and before/after examples.

Validation: library build, documentation generation, formatting and diff checks passed. All 37 compiled CSS files match the baseline after resolving the added compatibility wrappers to their legacy form. Browser checks verified legacy variable values, new-name precedence, and identical opt-out behavior for both class names.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread src/styles/utils/api.scss
Comment on lines +5 to +6
$background-rgb: var(--ios-theme-glass-background-rgb, var(--ios26-glass-background-rgb)),
$border-color-rgb: var(--ios-theme-glass-border-color-rgb, var(--ios26-glass-border-color-rgb)),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 内部オーバーライドが旧変数名のみを設定しており新名採用時に無効化される

境界色の読み取りは var(--ios-theme-glass-border-color-rgb, var(--ios26-glass-border-color-rgb)) に変わったが、ダークのクローン要素--ios26-glass-border-color-rgb: 120, 120, 120 のみを設定する(tab側も同様)。既定では新名が未定義のためフォールバックで従来動作は保たれる。しかし移行ガイド通り利用者が --ios-theme-glass-border-color-rgb をグローバル設定すると新名が優先され、この内部オーバーライドが無視される。メニューの transparent 指定も同じ構図。内部オーバーライドに新名の併記が必要か確認を。

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  90 passed

Details

stats  90 tests across 2 suites
duration  1 minute, 53 seconds
commit  31cd8e1
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-145/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-145/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-145/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-145/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-145/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@rdlabo
rdlabo merged commit 8300fe0 into ios26 Sep 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant